chore: consistently enforce line endings #7069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently enforce line endings regardless of what operating system is used.
|
note that I added .bat & .cmd in case the repo will someday have a bat or cmd file (so it doesn't become a pitfall) |
|
I'm not sure what impact these changes would have to existing repositories of developers. Since there is no real benefit i don't think this change should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently enforce line endings regardless of what operating system is used.
Good article about this: https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git
If you think this is unnecessary, just close the pr. Though it wouldn't hurt to adopt this.
Existing files won't be changed (unless you specifically use a git cmd like
git add --renormalize .).