refactored codebase a/c napoleon style #979
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mr-tz @williballenthin I have made changes using the isort , for the code style. |
|
please fix isort/black issues first |
|
Corrected the isort and black issues @mr-tz |
|
code style looks good now, this will take a bit to go through also other tests fail, need to look into those |
|
Can you look into the test failures, please? |
|
@mr-tz Sure ill look into it. |
|
Can you rebase this to master to (maybe) fix the test failures, please? Otherwise, we have to look closer at them. |
|
@mr-tz Sure i will take a look. |
RahulSankhla312
force-pushed
the
napoleon
branch
from
2ce601e
to
a0ee25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the whole codebase Refactored codebase to consistently use Napoleon-style docstrings.
Improves code readability and maintainability by providing clear function and class descriptions.