Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetMemoryInformation request to kerncfg/posix #582

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Oct 20, 2023

No description provided.

@avdgrinten
Copy link
Member

Getting informative data from the kernel is better done by adding a kerncfg request. That way, we don't need to add a lot of additional syscalls, and it's easier to do access control and versioning.

@Qwinci
Copy link
Contributor Author

Qwinci commented Oct 23, 2023

I moved it to kerncfg like you suggested.

@Qwinci Qwinci changed the title thor: Add helGetMemoryInformation syscall Add GetMemoryInformation request to kerncfg/posix Oct 23, 2023
Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, although I'm unsure if this is the right time to start using separate response messages instead of adding fields to the SvrResponse message.

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants