Only write ref key once when writing with prune_previous_versions #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
commented
May 9, 2024
alexowens90
reviewed
May 10, 2024
… pytest continues to run indefinitely even after the tests have passed.
|
PR #1355 also added a overwrite_symbol_tree is used in:
recover_deleted is only used in tests remove_and_rewrite_version_keys is unused scan_and_rewrite is used in |
…e symbol ref key.
Usage:
write_entry_to_storage
|_ compact_and_remove_deleted_indexes (unused, no impact)
|_ writes the symbol ref a second time
|_ overwrite_symbol_tree
|_ writes the symbol ref a second time
|_ rewrite_entry
|_ recover_deleted
|_ writes the symbol ref a second time
|_ remove_and_rewrite_version_keys
|_ writes the symbol ref a second time
|_ scan_and_rewrite
|_ writes the symbol ref a second time
overwrite_symbol_tree is used in:
initial sync process in replication (no impact really, we don't expect stuff to be readable during the initial sync)
fix_symbol_trees (unused)
recover_deleted is only used in tests
remove_and_rewrite_version_keys is unused
scan_and_rewrite is used in fix_ref_key which is unused
Testing limited as most call sites are unused. I verified that replication still works correctly after this change.
poodlewars
commented
May 15, 2024
build_tooling/parallel_test.sh
Outdated
There was a problem hiding this comment.
These changes are just formatting.
…'t hang the CI suite for 6 hours...
alexowens90
approved these changes
May 15, 2024
poodlewars
added a commit
that referenced
this pull request
May 15, 2024
) #### What does this implement or fix? We should only write the version ref key once when we write with `prune_previous_versions=True`. Currently we are writing it twice - once after we write the tombstone all and once when we write the new version. This means that there is a period of time where the symbol is unreadable. This was fixed a while ago with PR #1104 but regressed with PR #1355.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement or fix?
We should only write the version ref key once when we write with
prune_previous_versions=True. Currently we are writing it twice - once after we write the tombstone all and once when we write the new version. This means that there is a period of time where the symbol is unreadable.This was fixed a while ago with PR #1104 but regressed with PR #1355.
Any other comments?
Checklist
Checklist for code changes...