New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1148: Show clearer error message for mismatched types in QueryBuilder #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadhamzasajjad
force-pushed
the
bug/query_type_mismatch_message
branch
from
May 8, 2024 17:06
718555f
to
c3d2bf5
Compare
muhammadhamzasajjad
force-pushed
the
bug/query_type_mismatch_message
branch
from
May 9, 2024 09:33
c3d2bf5
to
6e043ee
Compare
muhammadhamzasajjad
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
May 9, 2024 11:08
alexowens90
requested changes
May 10, 2024
muhammadhamzasajjad
force-pushed
the
bug/query_type_mismatch_message
branch
from
May 10, 2024 18:34
108a9dc
to
57f9e57
Compare
… tests to expect UserInputException
muhammadhamzasajjad
force-pushed
the
bug/query_type_mismatch_message
branch
from
May 13, 2024 08:37
57f9e57
to
d8fd962
Compare
alexowens90
requested changes
May 13, 2024
muhammadhamzasajjad
force-pushed
the
bug/query_type_mismatch_message
branch
from
May 14, 2024 15:57
d6cabc9
to
5486084
Compare
alexowens90
requested changes
May 16, 2024
muhammadhamzasajjad
force-pushed
the
bug/query_type_mismatch_message
branch
from
May 16, 2024 15:51
f38f333
to
18beb3f
Compare
alexowens90
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1148.
previously if a type was mismatched in the QueryBuilder as follows
it would show an unclear message with
UTF_DYNAMIC64
type shown for stringsNow the error is much clearer where column names are generated according to the query and STRING type is shown for strings
For a more complex query like
q = q[1 + q["col1"] * q["col2"] - q["col3"] == q["col_str"]]
it will show column name((1 + (col1 * col2)) - col3)
in the error message which allows the user to better understand the error.What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...