Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build time #1549

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Improve build time #1549

wants to merge 1 commit into from

Conversation

G-D-Petrov
Copy link
Collaborator

  • Fix compilation errors with clang-18 due to Werror
  • Run include-what-you-use to reduce includes and add forward declarations

Test building on ec2

Set upper limit for build threads in benchmark flow

Revert change

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@G-D-Petrov
Improve build time
f7e71ae 
- Fix compilation errors with clang-18 due to Werror
- Run include-what-you-use to reduce includes and add forward
  declarations

Test building on ec2

Set upper limit for build threads in benchmark flow

Revert change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 will be requested when the pull request is marked ready for review alexowens90 is a code owner

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry will be requested when the pull request is marked ready for review willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars will be requested when the pull request is marked ready for review poodlewars is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@G-D-Petrov