Store naming #1528
Merged
Store naming #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-D-Petrov
force-pushed
the
store_naming
branch
from
581eabb
to
25d49c2
Compare
Update S3 and Azure library adapter configurations in helper.py Update storage library classes to include a uid() method Update AzureStorage class to include container_name_ member variable
G-D-Petrov
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
alexowens90
requested changes
May 20, 2024
alexowens90
reviewed
May 20, 2024
| @@ -300,6 +300,10 @@ bool do_key_exists_impl( | |||
| } | |||
| } //namespace detail | |||
|
|
|||
| std::string AzureStorage::name() const { | |||
| return fmt::format("azure_storage-{}/{}", root_folder_, container_name_); | |||
There was a problem hiding this comment.
Are these the right way round?
alexowens90
reviewed
May 20, 2024
| @@ -168,7 +168,8 @@ class Library { | |||
| } | |||
|
|
|||
| std::string name() { | |||
| return library_path_.to_delim_path(); | |||
| auto lib_name = storages_->name(); | |||
| return lib_name; | |||
There was a problem hiding this comment.
Why not just return storages_->name();?
There was a problem hiding this comment.
This way it is easier to debug (at least in VSCode) and shouldn't really make a difference in a release build
alexowens90
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
This PR is aiming to provide a way to get the name/identifier of a given store.
This is what the identifier looks like now - s3_storage-us-east-1/test_bucket_1/local/lib-kOGPh-3-True-target-1