Improve build time #1516
Closed
Improve build time #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasil-pashov
force-pushed
the
iwyu
branch
2 times, most recently
from
b82f64b
to
89c206d
Compare
vasil-pashov
force-pushed
the
iwyu
branch
3 times, most recently
from
f3cde62
to
dd2e60d
Compare
- Fix compilation errors with clang-18 due to Werror - Run include-what-you-use to reduce includes and add forward declarations
vasil-pashov
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
|
Checks are failing due to ASV failing to perform some git commands. The bug is reported here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: #1474 in the original PR ASV fails to perform some git commands, the issue seems to be related to branch naming.
TLDR
Using the suggestions from include-what-you-use makes full builds ~10% faster sparing 20s on a local machine (Processor: 13th Gen Intel(R) Core(TM) i7-1370P, 1900 Mhz, 14 Core(s), 20 Logical Processor(s)) building with 20 threads.
Build info:
OS: Ubuntu (WSL)
Compiler: Clang 18
Linker: Mold
Build system: Ninja
(Clang and Mold are custom builds using additional flags -O3 -march=native -flto=full, arcticdb is built as usual)
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...