maint: Remove use of folly/hash/Hash.h #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Thomas <ianthomas23@gmail.com>
17 tasks
jjerphan
reviewed
May 14, 2024
Comment on lines
+105
to
+112
| auto seed = hash(id_); | ||
| boost::hash_combine(seed, version_id_); | ||
| boost::hash_combine(seed, creation_ts_); | ||
| boost::hash_combine(seed, content_hash_); | ||
| boost::hash_combine(seed, key_type_); | ||
| boost::hash_combine(seed, index_start_); | ||
| boost::hash_combine(seed, index_end_); | ||
| hash_ = seed; |
There was a problem hiding this comment.
I think the returned values of get_cached_hash must not change for backward compatibility (e.g. to be able to retrieve segments which have been stored in databases in previous versions).
Is there a way we could test that?
There was a problem hiding this comment.
I don't think that's the case, however I agree we should check. I believe we have version backwards and forwards compatibility checks, I'll find out where they are and point you at them
jjerphan
changed the title
jjerphan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes the 5th item of the folly replacement plan, issue #1412.
What does this implement or fix?
This removes the single include of
folly/hash/Hash.h. The only explicit use of this isfolly::hash::hash_combinewhich I have replaced with use ofboost::hash_combine.It would alternatively be possible to vendor the 3 or so
follyfunctions, but I have rejected this idea. One of the functions ishash_128_to_64and is taken from cityhash which is essentially unmaintained for 11 years. I would rather use the actively maintainedboost.Any other comments?
There are some tests of
folly::hash::commutative_hash_combineintest_hash.cpp, but this function is not used anywhere else in the ArcticDB code base so I have removed the test code as not being relevant.