New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openssl3 in pypi #1489
Update openssl3 in pypi #1489
Conversation
73a88d2
to
0accd0c
Compare
a9c062b
to
0551881
Compare
@@ -44,7 +44,7 @@ RUN rpmkeys --import 'https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x3F | |||
s/#?exclude.*/exclude=.edu/' /etc/yum/pluginconf.d/fastestmirror.conf | |||
ADD sccache /usr/local/bin/ | |||
RUN yum update -y && \ | |||
yum install -y zip jq less devtoolset-11-gdb \ | |||
yum install -y zip jq less devtoolset-11-gdb perl-IPC-Cmd \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need perl-IPC-Cmd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required by v3 compilation:
https://github.com/man-group/ArcticDB/actions/runs/8649691810/job/23716646005
Can't locate IPC/Cmd.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at -e line 1.
BEGIN failed--compilation aborted at -e line 1.
CMake Error at buildtrees/versioning_/versions/openssl/53fb72a19981a3439cd569f58b722ca6cd26e23d/unix/portfile.cmake:27 (message):
Perl cannot find IPC::Cmd. Please install it through your system package
manager.
Underlying reason is the configure
script of lastest openssl
is a perl
script:
openssl/openssl#19740 (comment)
Change looks fine. What test coverage do we have for our SSL interaction? Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not. |
0551881
to
397f2ba
Compare
#1338
Good point. Let me turn it on |
@poodlewars It is on now. |
304e974
to
5f75a0e
Compare
6e14e26
to
4f7bd59
Compare
@phoebusm can you share a link showing it passing please? |
|
8b6ed09
to
1256b6a
Compare
Reference Issues/PRs
#1491
What does this implement or fix?
Update openssl to v3
Any other comments?
Checklist
Checklist for code changes...