hiscore: gnw_dkjr: Donkey Kong Jr (New Wide Screen) #12377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Separate pull requests per game are appreciated, Github makes it annoying to review PRs when there's a lot of commits. FYI, official hiscore.dat at least used to be Leezer's at https://highscore.mameworld.info/ but it looks like they haven't had a release in a while and we haven't synced in at least that long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for saving hi scores (game A and B) for Game & Watch Donkey Kong Jr. using hiscore plugin.
Tested in Batocera Linux v39 (MAME v0.261)
EDIT: this is my first contribution - I read the documentation and could get more input as to the best way to add other Game & Watch driver updates to hiscore.dat as I complete & validate them. Should I just keep adding commits to this branch until it is merged (what I’m planning to do as I don’t expect this pull request to be processed immediately) or create separate pull requests?