Add front panel keypad to Heathkit H8. Added support for serial console. #12053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Feb 22, 2024
src/mame/layout/h8.lay
Outdated
Comment on lines
184
to
187
| <element ref="btn_7" inputtag="X0" inputmask="0x80"><bounds x="0.20" y="0.125" width="1.0" height="1.0" /></element> | ||
| <element ref="btn_8" inputtag="X1" inputmask="0x01"><bounds x="1.25" y="0.125" width="1.0" height="1.0" /></element> | ||
| <element ref="btn_9" inputtag="X1" inputmask="0x02"><bounds x="2.30" y="0.125" width="1.0" height="1.0" /></element> | ||
| <element ref="btn_a" inputtag="X1" inputmask="0x04"><bounds x="3.35" y="0.125" width="1.0" height="1.0" /></element> |
There was a problem hiding this comment.
One of the lines here got indented more than the others. Please use one tab per nesting level for indentation, and don’t indent using spaces.
src/mame/layout/h8.lay
Outdated
Comment on lines
207
to
209
| <element ref="background"> | ||
| <bounds left="1" top="65" right="600" bottom="200" /> | ||
| <bounds left="1" top="65" right="900" bottom="400" /> | ||
| </element> |
There was a problem hiding this comment.
Doing this will cause space for the keypad to always appear even if the user hides the keypad collection. That’s undesirable. Can you do the layout in a way that will avoid that?
Also, 400 seems excessive extra height when the keypad is 200 units high with only a margin of 5 units at the top.
|
Pull request has been updated to address review comments. |
|
@cuavas Please review the revised pull request when you get a chance. |
jefftranter
changed the title
|
Made additional changes to support serial console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a graphical front panel keypad to the Heathkit H8.