New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repodata config to channel #530
Add repodata config to channel #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im a bit on the fence if adding this to channel makes sense responsibility wise. It makes sense when fetching repodata but its used in many more places were it doesnt make sense.
Let me mull it over a little.
pub repodata_options: Option<ChannelRepodataConfig>, | ||
} | ||
|
||
fn _serde_is_true(value: &bool) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefixing with _ would mean its unused. I assume you want to make it private to the module, if you dont add "pub" that should be fine.
I have been thinking about this and I think we need to alter the design a little bit. I think we need to split this functionality into two: In pixi we can then change some of the logic to work with |
With the new Gateway API, it is now possible to set configuration per channel. Im closing this, feel free to reopen if you think this PR still adds more value. |
This builds on some of the idea of #420
When fetching from certain channels it would be handy to disable some of the repodata methods that are known to be expensive / non-functional.
This is particularly true for artifactory where the HEAD request for the .bz2 repodata will eager compress the contents and not cache it. :(
Idea is that in downstream tools like pixi a user can define their channel and add some of these options in