Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in matchspec parser #640

Open
aochagavia opened this issue May 3, 2024 · 1 comment
Open

Fix panic in matchspec parser #640

aochagavia opened this issue May 3, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aochagavia
Copy link
Contributor

The matchspec parser contains a call to unimplemented! (see here). For a program that accepts arbitrary matchspecs, that means specific matchspecs could cause the program to unexpectedly crash. I think it'd make sense to extend ParseMatchSpecError with an additional variant for unimplemented bits, to avoid panics.

Would you welcome a PR for this?

@wolfv
Copy link
Member

wolfv commented May 3, 2024

Sounds good to me! Even better would be to implement whatever conda does there :) but getting rid of panics is always good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants