Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add functionality to install package files #644

Open
vnling opened this issue May 6, 2024 · 6 comments
Open

[Feature Request] Add functionality to install package files #644

vnling opened this issue May 6, 2024 · 6 comments

Comments

@vnling
Copy link

vnling commented May 6, 2024

Desired behavior: The matchspec parser can parse specs such as package.tar.bz2

Currently I run into unimplemented code when trying to parse package file specs, as described in #640. Can I ask if implementing this is on the roadmap for the team? If not, would a contribution to add this functionality need to handle anything additional on the package linking side, or is it just a matter of adding the matchspec parsing logic?

@baszalmstra
Copy link
Collaborator

TBH Im not entirely sure as I'm not entirely sure how it should work.

Do you have some examples and how you expect it would work?

But any contribution would be appreciated!

@vnling
Copy link
Author

vnling commented May 6, 2024

I assume it would be replicating the logic in https://github.com/conda/conda/blob/2ca3d3532a176b4ece917d4cf39ab5ca47ffec6c/conda/models/match_spec.py#L631-L642? Happy to give it a shot, just wanted to know if it was something the team was working on already. Thanks!

@baszalmstra
Copy link
Collaborator

Thanks! Yeah, that looks simple enough. I think from the MatchSpec struct we are missing the url field. This should then probably also be added (and to NamelessMatchSpec).

@wolfv
Copy link
Member

wolfv commented May 6, 2024

@vnling no one is currently working on this - feel free to give it a shot. You can also join our Discord in case you need any help :)

@iamthebot
Copy link
Contributor

@vnling just curious if you're working on this, if not I can probably throw up a PR since this will eliminate a lot of code on my side :)

@vnling
Copy link
Author

vnling commented May 14, 2024

Hey @iamthebot, am not currently working on it, happy for you to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants