Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten Windows installation command. #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Shorten Windows installation command. #20

wants to merge 1 commit into from

Conversation

YouJiacheng
Copy link

@YouJiacheng YouJiacheng commented Nov 7, 2023 •
edited

#19

@pavelzw
Copy link
Member

pavelzw commented Nov 7, 2023 •
edited

I don't really have strong opinions but I've also seen iwr -useb in some other places instead of irm. ChatGPT says that irm is typically used when dealing with APIs that return structured data like XML or JSON. Maybe Invoke-WebRequest makes more sense here since this is only a plain file?

@YouJiacheng
Copy link
Author

YouJiacheng commented Nov 7, 2023 •
edited

PowerShell use Invoke-RestMethod
https://github.com/PowerShell/PowerShell/blob/504b6e0e6be5498421ccf01b1ae087f2cde7bcca/tools/install-powershell.ps1#L25

Deno use Invoke-RestMethod
https://github.com/denoland/deno_install

pavelzw
pavelzw approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to write some CI tests at some point as we do for install.sh

@pavelzw
Copy link
Member

pavelzw commented Nov 19, 2023

@AntoinePrv

@AntoinePrv
Copy link
Member

I don't have much knowledge about anything Windows :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelzw pavelzw pavelzw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YouJiacheng @pavelzw @AntoinePrv