Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set umask in _dockerfile_shell.sh when given #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maresb
Copy link
Collaborator

@maresb maresb commented Jun 14, 2022

I've been cleaning up my https://github.com/maresb/micromamba-devcontainer project, and I noticed that I implemented this feature but never actually used it.

Instead of deleting it there, I wanted to offer it here. If you think it could be helpful, I will write tests sometime soon.

@wholtz
Copy link
Member

wholtz commented Jun 14, 2022

Yes, I certainly see use-cases for this. We will need some tests, a description in the README.md and a mention in the CHANGELOG.md. Thanks @maresb !

@maresb
Copy link
Collaborator Author

maresb commented Jun 14, 2022

Cool! I'll probably need a week or two to find the time, but I'll do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants