Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new environment using a remote mamba solver #141

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mariobuikhuizen
Copy link

Point quetz_url and quetz_solve_url in packages/common/src/components/CondaHints.ts to your Quetz server/solver.

On the Quetz server with the solver add:

[cors]
allow_origins=["*", "http://localhost"]

to config.toml

The code completion in the environment editor can be activated with CTRL-space.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on the branch mariobuikhuizen/gator/mamba_hint_solve

The code completion in the environment editor can be activated
with CTRL-space.
@mariobuikhuizen
Copy link
Author

gator1.mp4

@fcollonval
Copy link
Member

Thanks a lot for this awesome feature @mariobuikhuizen

I'll try to review it in the coming days.

One design question from the demo (thanks for it); did you think about various design? For example, does it make sense to open a new mainwidgetarea containing the editor with the button as toolbar button? The idea would be to create/edit environment file in a standalone widget directly from the filebrowser in addition to the demo you are presenting.

@mariobuikhuizen
Copy link
Author

That sounds like a good idea @fcollonval, I'll look into that.

@mariobuikhuizen
Copy link
Author

Thanks @hbcarlos!

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this awesome feature. I left some comments; mainly I think the code could be simplified by reusing the import feature directly. And I'm worry that fetching the quetz server should be proxied through the server extension instead of being done on the frontend to avoid CORS errors.

mamba_gator/envmanager.py Outdated Show resolved Hide resolved
mamba_gator/handlers.py Outdated Show resolved Hide resolved
packages/common/src/components/CondaHint.ts Show resolved Hide resolved
packages/common/src/components/CondaHint.ts Outdated Show resolved Hide resolved
packages/common/src/components/CondaHint.ts Outdated Show resolved Hide resolved
packages/common/src/components/NbConda.tsx Outdated Show resolved Hide resolved
packages/common/src/components/CondaHint.ts Show resolved Hide resolved
packages/common/src/services.ts Outdated Show resolved Hide resolved
mamba_gator/handlers.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@fcollonval fcollonval self-requested a review June 17, 2021 12:37
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mariobuikhuizen I added some comments.

mamba_gator/navigator/main.py Outdated Show resolved Hide resolved
packages/common/src/components/CondaEnvSolve.tsx Outdated Show resolved Hide resolved
packages/common/src/components/CondaEnvSolve.tsx Outdated Show resolved Hide resolved
packages/common/src/components/CondaEnvSolve.tsx Outdated Show resolved Hide resolved
mamba_gator/navigator/main.py Outdated Show resolved Hide resolved
packages/common/src/tokens.ts Show resolved Hide resolved
packages/labextension/schema/plugin.json Outdated Show resolved Hide resolved
packages/labextension/src/CondaCompleteEditor.tsx Outdated Show resolved Hide resolved
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@mariobuikhuizen
Copy link
Author

I discovered an issue with setting arguments with the standalone navigator with jupyter_server 1.9 (in 1.6.1 it works). Taking a look at that now.

@mariobuikhuizen
Copy link
Author

I think it's an issue in jupyter-server: jupyter-server/jupyter_server#550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants