Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kay D rps challenge #2135

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Kay D rps challenge #2135

wants to merge 5 commits into from

Conversation

kaykakaraka
Copy link

No description provided.

davekempsell
davekempsell reviewed Jun 6, 2022
View reviewed changes
Copy link

@davekempsell davekempsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really clear how your program works, and the thorough testing further adds to that. nice job!

app.rb
redirect ('/result')
end

get '/result' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a clear and concise way of displaying who has won the game.

spec/features/choose_spec.rb
end
end

feature 'player 1 chooses rock' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the second and third tests here are redundant if the first one is working?

spec/features/result_spec.rb
end

feature 'player 1 picks rock and player 2 picks paper' do
scenario 'shows player 1 as the winner' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should say "shows player 2 as the winner"

lib/game.rb
@player2 = player2
end

def winner
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution to the coding of the game of rock, paper, scissors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davekempsell davekempsell davekempsell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaykakaraka @davekempsell