Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellie's RPS #233

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Ellie's RPS #233

wants to merge 9 commits into from

Conversation

estoltzy
Copy link

No description provided.

@@ -0,0 +1 @@
Make your choice Charlotte

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to get these to go into a .gitignore folder?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is! something like this should do it:

capybara-*.html


RULES = { rock: :scissors,
paper: :rock,
scissors: :paper }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way of handling the rule logic here

Copy link

@lacurnow lacurnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, only a few comments!

Copy link
Contributor

@alicelieutier alicelieutier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reply to one of the comments :)

Good job overall, would have loved to see that result in action!

@@ -0,0 +1 @@
Make your choice Charlotte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is! something like this should do it:

capybara-*.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants