Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request - Stephanie #226

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

stephaniesomade
Copy link

@stephaniesomade stephaniesomade commented Apr 4, 2022

Your name

Please write your full name here to make it easier to find your pull request.

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • User story 1: "I want to see all the messages (peeps) in a browser"
  • User story 2: "I want to post a message (peep) to chitter"
  • User story 3: "I want to see the date the message was posted"
  • User story 4: "I want to see a list of peeps in reverse chronological order"
  • User story 5: "I want to filter on a specific keyword"

README checklist

Does your README contains instructions for

  • how to install,
  • how to run,
  • and how to test your code?

Here is a pill that can help you write a great README!

Copy link

@PhilipCarr1 PhilipCarr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good, solid start, looks like good foundations to finish the challenge :)

erb :post
end

post '/postpeep' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This route might be clearer and stick to conventions better if it were called '/peep/new'

end

def self.all
if ENV['ENVIRONMENT'] == 'test'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you not use the db setup helper here to remove this if else statement?

@tomfuller
Copy link

This is a really nice solution but it appears you have added user specific functionality before implementing the functionality from the user stories? You should always prioritise the functionality described in user stories that the business requires over nice to haves. It would also be really nice to see the README updated to include functionality finished and running instructions. I have left a couple inline comments where there are small things that could be improved. If you have any questions about any of this please let me know and we can chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants