Rebase & adding support for MatchGroup in Payload #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update actions/checkout from v2 to v3 to resolve node EOL issue. Update actions/setup-go from v2 to v4 for improved Go features
Update actions to latest version to remove node EOL warnings
commit c1d41c0 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 18:24:20 2023 +0100 Update Makefile commit 09acff4 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 16:21:56 2023 +0100 Update buildspec.yml commit 95c1fec Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 16:05:18 2023 +0100 Switching to bootstrap commit 038c4d8 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 15:26:48 2023 +0100 Adjust for testing commit fce63c4 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 14:25:32 2023 +0100 updates for the developer pipeline commit 0542ed4 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 12:30:09 2023 +0100 Update buildspec.yml commit 627c24c Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 11:49:56 2023 +0100 Updates to CICD for arm64 commit b3a4c8c Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 11:09:20 2023 +0100 Update buildspec.yml commit 323eaf6 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 10:55:37 2023 +0100 Update buildspec.yml commit da30515 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 10:46:16 2023 +0100 Update buildspec.yml commit 64a25b2 Author: Chris Pates <crpates@amazon.co.uk> Date: Wed Oct 25 09:47:32 2023 +0100 Switching back to amd64 images for codebuild commit 7b87d0f Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 20:29:53 2023 +0100 update codebuild image and fix golang version. commit 338b61f Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:45:14 2023 +0100 Update buildspec.yml commit 21c941d Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:41:01 2023 +0100 Update buildspec.yml commit cb9d94b Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:39:09 2023 +0100 Update buildspec.yml commit 0dc4087 Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:31:21 2023 +0100 Update buildspec.yml commit dd0f19c Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:27:17 2023 +0100 Update buildspec.yml commit 71ba543 Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:20:44 2023 +0100 Update buildspec.yml commit 43af171 Author: Chris Pates <crpates@amazon.co.uk> Date: Tue Oct 24 17:13:25 2023 +0100 updating cicd to arm64
Make the Lambda timeout setting user configurable
This reverts commit 278ce0f.
Reinstate Region parameter for continuity, postpone retirement until v3.x
Update regexes to validate parameters Allow empty parameters and use conditions to only create env vars where parameters have been set.
Added Empty string Default values.
Additional parameter condition logic.
Improved param validation
Adding log retention parameter Improving UI feedback for parameters.
michelleparent
approved these changes
Nov 14, 2023
Comment on lines
+155
to
+159
| // if inputConfig.UserName != "" { | ||
| // cfg.UserMatch = inputConfig.UserName | ||
| // log.Infof("Overriding UserMatch with %s", inputConfig.UserName) | ||
| // } | ||
|
|
There was a problem hiding this comment.
oh I see - if you want to leave this here maybe we can add a comment on how to use it
There was a problem hiding this comment.
I can add a comment, wanted to include it incase we ever wanted to get it to the user level, will add a note
| ScheduleExpression: | ||
| Type: String | ||
| Description: Schedule for trigger the execution of ssosync (see CloudWatch schedule expressions) | ||
| Default: rate(15 minutes) | ||
| AllowedPattern: '(?!.*\s)|rate\(\d{1,3} (minutes|hours|days)\)|(cron\((([0-9]|[1-5][0-9]|60)|\d\/([0-9]|[1-5][0-9]|60)|\*) (([0-9]|[1][0-9]|[2][0-3])|(\d\/([0-9]|[1][0-9]|[2][0-3]))|(([0-9]|[1][0-9]|[2][0-3])-([0-9]|[1][0-9]|[2][0-3]))|\*) (([1-9]|[1-2][0-9]|[3][0-1])|\d\/([1-9]|[1-2][0-9]|[3][0-1])|[1-5]W|L|\*|\?) (([1-9]|[1][1-2])|(JAN|FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV|DEC)|((JAN|FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV)-(FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV|DEC))|(JAN|FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV)(,(FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV|DEC)){0,11}|\d\/([0-9]|[1][0-2])|\?|\*) ((MON|TUE|WED|THU|FRI|SAT|SUN)|(MON|TUE|WED|THU|FRI|SAT)-(TUE|WED|THU|FRI|SAT|SUN)|(MON|TUE|WED|THU|FRI|SAT)(,(TUE|WED|THU|FRI|SAT|SUN)){0,6}|[1-7]L|[1-7]#[1-5]|\?|\*) ((19[7-9][0-9]|2[0-1]\d\d)|(19[7-9][0-9]|2[0-1]\d\d)-(19[7-9][0-9]|2[0-1]\d\d)|(19[7-9][0-9]|2[0-1]\d\d)(,(19[7-9][0-9]|2[0-1]\d\d))*|\*)\))' |
There was a problem hiding this comment.
Why they don't just use something like cron syntax baffles me to this day 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are from the rebase, more configuration may be needed since it looks like some more providers are supported now, all changes pertaining to supporting setting the group to match on are in
cmd/root.go.