Add support for HeatStorm HS-1500 heater #1763
Conversation
| value: Temp sensor fault | ||
| - dps_val: 2 | ||
| value: Tilt over | ||
| - dps_val: 3 |
There was a problem hiding this comment.
Are these values tested? Normally a fault code dp will be a bitfield (bitmap in tuya docs), so will have bits for each code. The value of the next bit after 2 is 4 (3 is bits 2+1).
If the value is really 3 for this fault code, then the type should probably be integer rather than bitfield, as the comparisons need to be done by exact value, not bit matching.
| - dps_val: "100" | ||
| value: 255 | ||
| - entity: lock | ||
| name: Child lock |
There was a problem hiding this comment.
Name and icon should be replaced by translation_key: child_lock
| - dps_val: false | ||
| value: true | ||
| - entity: binary_sensor | ||
| name: Fault |
There was a problem hiding this comment.
name should be removed, ut use the standard translations for problem class
| value: false | ||
| - value: true | ||
| - entity: select | ||
| name: Temperature unit |
There was a problem hiding this comment.
name and icon should be replaced with translation_key: temperature_unit and values be in all lower case to use translations.
|
@make-all Apologies on the delay here, I had an unexpected death in the immediate family and have been away for awhile. I will close on this soon. |
|
My condolences for your loss. I am actually in the same situation myself, which is delaying the next release and proper review of PRs which are starting to stack up. |
Add support for the HeatStorm HS-1500 wall mounted heater.
I validated DPs via Tuya developer account website with my own devices. It is mostly similar to the HS-6000 excepting some DPs, namely the hvac_mode one which is not present on the hs1500.