types boltons/dictutils.py #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blablatdinov
force-pushed
the
dictutils-types
branch
from
7a7a5c9
to
2b81822
Compare
blablatdinov
force-pushed
the
dictutils-types
branch
from
2b81822
to
7eb93ee
Compare
nichmor
reviewed
Oct 19, 2022
Co-authored-by: nichmor <nmorkotilo@gmail.com>
mahmoud
reviewed
Feb 20, 2023
There was a problem hiding this comment.
Very interesting! boltons's first .pyi, thank you for this. I have two high-level questions:
- I don't believe these are enforced anywhere. Is there a pytest or tox command that you'd recommend to validate these are correct?
- Any strong reasons for
.pyiinstead of embedding the typehints?
Thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.