Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support from Folder Dict, Now you can create a Dict for a folde… #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AI-IshanBhatt
Copy link

Now you can create a Dict for a folder and access their files like a dictionary.
The opening of a file, closing of a file is done automatically.
Also, the listing of files is supported by dict.keys()
File deletion is supported by del dict["File_name"] or dict.pop("File_Name")

…r and access their files like a dictionary
@AI-IshanBhatt
Copy link
Author

Are you still supporting Python 2.7 ?

@crazymerlyn
Copy link
Contributor

@AI-IshanBhatt The project readme mentions that the library is tested for python 2.6 and python 2.7

@AI-IshanBhatt
Copy link
Author

Let me change the code so that it works on all versions. Thanks man.

@AI-IshanBhatt
Copy link
Author

Can anyone help me here?
Build is failing for Python3.7 and that too on a totally unrelated file.

@crazymerlyn
Copy link
Contributor

@AI-IshanBhatt Looks like a regression in python 3.7.1 as the code passes just fine on 3.7.0. It could also be OrderedMultiDict relying on some unspecified behavior of python3.7 dicts.
Either way, it's not due to this PR.

@AI-IshanBhatt
Copy link
Author

I am a newbie in open source, Can you help me with what would be next steps?

@crazymerlyn
Copy link
Contributor

@AI-IshanBhatt There's no fixed next step. You could try and debug the problem with OrderedMultiDict and depending on the source of the problem, add a PR to either this repository or the cpython repository. Or if you are not interested in that, you could just wait for a maintainer to see the issue and decide whether it's ok to merge this PR despite the failed CI.

@AI-IshanBhatt
Copy link
Author

@mahmoud Can you please look into this as well?

@mahmoud
Copy link
Owner

mahmoud commented Dec 23, 2018

Hey there! The 3.7 issue has been fixed on master, which closed #179. If you rebase you should see things pass.

I'm still contemplating where to include this. I think this probably fits best in fileutils.py. I'll need to review the code some more. Biggest issue I see is inheriting from dict, which can have some odd API behavior, coincidentally demonstrated by the 3.7 failures you saw here. Maybe we can inherit from collections.Mapping or something maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants