Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pydata-sphinx-theme #762

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Migrate to pydata-sphinx-theme #762

wants to merge 29 commits into from

Conversation

Alexboiboi
Copy link
Member

@Alexboiboi Alexboiboi commented Apr 20, 2024

Merge after #776

Related issues

The pydata-sphinx-theme is quite widely used in the scientific python community and has the version switcher integrated. We will loose the live code feature though.

Note that the version switcher does not work locally or on the PR rtd link. We will have to merge first ( see pydata/pydata-sphinx-theme#647)

@OrtnerMichael
Copy link
Member

hi @Alexboiboi

Its nice.
It would require restructuring the webpage a little bit - nothing that cannot be done quickly.

But I also see no major advantage - except that the version switcher is there.

What do you think ? What would be major reasons to switch ?

br michael

@OrtnerMichael OrtnerMichael marked this pull request as ready for review May 21, 2024 04:12
@Alexboiboi
Copy link
Member Author

Alexboiboi commented May 28, 2024

Hi @OrtnerMichael,

I just bumped sphinx version from 7.2 to 7.3. This solved the search issue raised in #781 and as a side effect the flyout is now also back ^^
image

@Alexboiboi
Copy link
Member Author

@OrtnerMichael You will need to tell me when this PR is ready for review btw ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search on readthedocs never returns anything readthedocs version switcher (=flyout) is missing from docs
2 participants