Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mayavi plotting backend #549

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

Mayavi plotting backend #549

wants to merge 45 commits into from

Conversation

Alexboiboi
Copy link
Member

@Alexboiboi Alexboiboi commented Jul 26, 2022

Related Issues

#539

This PR implements a new mayavi using the new plotting logic from #539.

Tasks

  • changelog
  • tests (animation has to be tested manually)
  • docstrings
  • docs
  • fix CI checks

Check feature parity table here

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (59b71f0) 99.77% compared to head (956d133) 97.96%.
Report is 736 commits behind head on main.

❗ Current head 956d133 differs from pull request most recent head d0ccbf4. Consider uploading reports for the commit d0ccbf4 to get more accurate results

Files Patch % Lines
magpylib/_src/display/backend_mayavi.py 11.81% 97 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   99.77%   97.96%   -1.81%     
==========================================
  Files          52       49       -3     
  Lines        5660     5457     -203     
==========================================
- Hits         5647     5346     -301     
- Misses         13      111      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alexboiboi Alexboiboi modified the milestones: 4.1, 4.2 Aug 7, 2022
@magpylib magpylib deleted a comment from lgtm-com bot Aug 8, 2022
@magpylib magpylib deleted a comment from lgtm-com bot Aug 8, 2022
@Alexboiboi Alexboiboi modified the milestones: 4.2, Future Jan 4, 2023
@Alexboiboi Alexboiboi added the needs discussion need to discuss about how to solve this label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs graphics needs discussion need to discuss about how to solve this new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants