fix(amf): Fix mobility updating registration #15403
Open
+337
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| msg->m5gs_mobile_identity.mobile_identity.imsi.type_of_identity); | ||
| if (msg->m5gs_mobile_identity.mobile_identity.guti.type_of_identity == | ||
| M5GSMobileIdentityMsg_GUTI && !(is_amf_ctx_new)) { | ||
|
|
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
|
|
||
| OAILOG_DEBUG(LOG_NAS_AMF, | ||
| "In process of registration mobility update: " | ||
| "GUAMFI: " PLMN_FMT".%u.%u.%u - " |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
| @@ -927,6 +927,8 @@ int ngap_amf_handle_ue_context_release_request(ngap_state_t* state, | |||
| asn_INTEGER2ulong(&ie->value.choice.AMF_UE_NGAP_ID, | |||
| (uint64_t*)&amf_ue_ngap_id); | |||
| } else { | |||
| OAILOG_ERROR(LOG_NGAP, | |||
| "UE CONTEXT RELEASE REQUEST invoked with missing Ngap_UEContextReleaseRequest_IEs (AMF_UE_NGAP_ID). Unable to process the message.\n"); | |||
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
|
@brunohcfaria: Can you please fix the lint errors. Fixes are given in - https://github.com/magma/magma/actions/runs/8601794520/job/23569853806?pr=15403 |
brunohcfaria
force-pushed
the
fix_mobility_updating_registration
branch
2 times, most recently
from
b10d0b9
to
e35f8ed
Compare
Krishnavamsi-wavelabs
force-pushed
the
fix_mobility_updating_registration
branch
from
e35f8ed
to
9bde599
Compare
|
Hi @brunohcfaria, It appears that the required CI jobs are failing, primarily due to a failing unit test case. Could you please address the issues with the test case. |
pull-request-size
bot
added
size/XL
github-actions
bot
added
component: ci
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the PR Check DCO after the last commit. |
brunohcfaria
force-pushed
the
fix_mobility_updating_registration
branch
from
346fe7e
to
34d5fb0
Compare
pull-request-size
bot
added
size/L
github-actions
bot
removed
component: nms
Fixes a bug where the Registration Request with Mobility
Registration Updating type was handled as a new registration,
causing duplicate sessions in AMF and SMF.
Signed-off-by: Bruno Faria <bruno.faria@ektrum.com>
Fixes a bug where the Registration Request with Mobility
Registration Updating type was handled as a new registration,
causing duplicate sessions in AMF and SMF.
Signed-off-by: Bruno Faria <bruno.faria@ektrum.com>
…Periodic Registration Modified the tests to not expect Identity Procedure when the TMSI is matched in guti hashtable. Signed-off-by: Bruno Faria <bruno.faria@ektrum.com>
panyogesh
force-pushed
the
fix_mobility_updating_registration
branch
from
34d5fb0
to
56b5fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Mobility Updating Registration Request reported in #1576 PR. which is marked as Draft and still had problems with duplicate sessions.
In summary, the AMF was not handling the Registration Request with Mobility Updating Type. That issue was observed in laboratory with SIMCOM devices. The test case was moving out of coverage and going back while running an iperf session. It was observed that when UE restablished the RRC Connection with the gNB it was resuming the NAS signaling by sending a Registration Request with type Mobility Updating. The AMF was unable to handle the procedure correctly leading to disconnection of the user.
Test Plan
The fix was tested with the same test-case presented above. The UE was moved out of coverage and it comes back which triggered the Mobility Updating procedure. The iperf session and pings where reestablished every time confirming the data session was kept.
Additional Information
Security Considerations