fix(amf): Added Security Indication IE

[shashidhar-patil]

Summary

Issue: MME rejected gNB registration

Observations from Pcap comparison:

• Security indication IE missing in magma pcap

Implemented security indication IE.

Test Plan

Tested with UERANSIM for service request scenario.
Attached Pcap and Logs: logs.zip

Additional Information

• This change is backwards-breaking

Security Considerations

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by PR DCO check.
• All PR titles must follow the semantic commits format. This is enforced by PR Check Title Or Commit Message.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first PR
• CI Checks for points of contact for failing or flaky CI checks
• Code Review Process for information on requesting reviews and contacting maintainers

[github-actions]

Bazel unit-test results --config=production

    1 files  ±    0    86 suites   - 43   3m 22s ⏱️ -3s
412 tests  - 193  412 ✔️  - 193  0 💤 ±0  0 ❌ ±0 
413 runs   - 193  413 ✔️  - 193  0 💤 ±0  0 ❌ ±0 

Results for commit ad55f8e. ± Comparison against base commit 81e4e77.

This pull request removes 193 tests.

ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

[github-actions]

Bazel unit-test results --config=production

1 files  ±    0  0 suites   - 129   0s ⏱️ - 3m 20s
0 tests  - 608  0 ✔️  - 608  0 💤 ±0  0 ❌ ±0 
0 runs   - 609  0 ✔️  - 609  0 💤 ±0  0 ❌ ±0 

Results for commit afd4b58. ± Comparison against base commit 50e0d51.

♻️ This comment has been updated with latest results.

[github-actions]

Bazel unit-test results --config=asan

1 files  ±    0  0 suites   - 129   0s ⏱️ - 3m 20s
0 tests  - 608  0 ✔️  - 608  0 💤 ±0  0 ❌ ±0 
0 runs   - 609  0 ✔️  - 609  0 💤 ±0  0 ❌ ±0 

Results for commit afd4b58. ± Comparison against base commit 50e0d51.

♻️ This comment has been updated with latest results.

[github-actions]

Bazel unit-test results

    1 files  ±    0    86 suites   - 146   3m 9s ⏱️ -17s
412 tests  - 314  412 ✔️  - 314  0 💤 ±0  0 ❌ ±0 
413 runs   - 314  413 ✔️  - 314  0 💤 ±0  0 ❌ ±0 

Results for commit ad55f8e. ± Comparison against base commit 81e4e77.

This pull request removes 314 tests.

ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

[github-actions]

Bazel unit-test results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0 ❌

Results for commit afd4b58.

♻️ This comment has been updated with latest results.

[github-actions]

[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<Ngap_PDUSessionResourceSetupRequestTransferIEs_t*>(...) instead [readability/casting] [4]

[github-actions]

[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<Ngap_MaximumIntegrityProtectedDataRate_t*>(...) instead [readability/casting] [4]

[lucasgonze]

Can you explain this more?

[Sathyaj27]

Changes looks good.

[shashidhar-patil]

Can you explain this more?

Hi @lucasgonze, this is a fix for issue: #15260

From pcap comparison between the working pcap and magma pcap, we observed that security indication IE is missing, which can be a probable cause for the issue.

Side note: Service request flow is successful when tested with UERANSIM.