Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nms): code scanning 120 #15267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lucasgonze
Copy link
Contributor

chore: fixes https://github.com/magma/magma/security/code-scanning/120, which is also https://github.com/magma/security/issues/146

Summary

Test Plan

See discussion at https://github.com/magma/security/issues/146#issuecomment-1642197543

Additional Information

  • This change is backwards-breaking

Security Considerations

Eliminated potential weakness

… which is also magma/security#146

Signed-off-by: Lucas Gonze <lucas@gonze.com>
@lucasgonze lucasgonze requested a review from a team as a code owner July 19, 2023 15:41
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 19, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jul 19, 2023
@github-actions
Copy link
Contributor

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 8cc32fb.

@github-actions
Copy link
Contributor

NMS Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 8cc32fb.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants