Skip to content
This repository has been archived by the owner on Mar 25, 2022. It is now read-only.

[alarms] update notistack version #71

Merged
merged 1 commit into from Feb 20, 2021
Merged

[alarms] update notistack version #71

merged 1 commit into from Feb 20, 2021

Conversation

Scott8440
Copy link
Contributor

@Scott8440 Scott8440 commented Feb 19, 2021

Signed-off-by: Scott8440 scott8440@gmail.com

To fix a security vulnerability of notistack.

Also had to do some small changes to material-ui stuff that was being imported improperly as of 4.0 which was breaking things in the snackbar.
mui/material-ui#15976 (comment)

Tested by publishing new version to private repo (verdaccio) and running prometheus-configmanager UI with the new package:
image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2021
Signed-off-by: Scott8440 <scott8440@gmail.com>
@@ -2495,6 +2495,9 @@ declare module "@material-ui/core/styles" {

declare module.exports: {
MuiThemeProvider: $Exports<"@material-ui/core/styles/MuiThemeProvider">,
makeStyles: <Props, Stl: Style<Props, string>>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really should be submitting this upstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

@Scott8440 Scott8440 merged commit 87e62da into master Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants