Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rare use of undefined variable #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starboerg
Copy link

@starboerg starboerg commented Jun 7, 2021

Variable x2 was used undefined in case of polygons without y-extend. Defaulting x2 to zero works around this issue.

x2 was used undefined in case of polygons without y-extend. Defaulting x2 to zero is works around this issue.
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #196 (54d1d6d) into master (ee30f6e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1107      1108    +1     
=========================================
+ Hits          1107      1108    +1     
Impacted Files Coverage Δ
src/svg.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee30f6e...54d1d6d. Read the comment docs.

@magjac
Copy link
Owner

magjac commented Feb 5, 2022

@starboerg Thanks for the contribution and apologies for the delay. Can you provide an example that trigger this? Or even better, add a test case?

@starboerg
Copy link
Author

@magjac I did not dive too deep into the code, just stumbled upon this issue. I use a sequence of graphs and transition them into each other:
graphviz.transition(function () { return d3.transition("main").ease(d3.easeLinear).delay(0).duration(500); });
Likely a horizontal line element in the graphs triggers this, but I did not keep any example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants