Merge pull request #32 from kschroeder/develop

Fixed the setting
magium · Feb 17, 2017 · 6e52cc1 · 6e52cc1
2 parents b4560df + e41d71a
commit 6e52cc1
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 21 deletions.
diff --git a/lib/Config/Storage/RelationalDatabase.php b/lib/Config/Storage/RelationalDatabase.php
@@ -117,6 +117,7 @@ public function setValue($path, $value, $requestedContext = Config::CONTEXT_DEFA
             'value'     => $value,
             'context'   => $requestedContext
         ]);
+        $insert = $insert->getSqlString($this->adapter->getPlatform());
         $this->adapter->query($insert);
         $this->data[$requestedContext][$path] = $value;
     }

diff --git a/lib/Console/Command/ConfigurationBuild.php b/lib/Console/Command/ConfigurationBuild.php
@@ -16,8 +16,6 @@ class ConfigurationBuild extends Command
 
     const COMMAND = 'magium:configuration:build';
 
-    protected $configurationFactory;
-
     protected function configure()
     {
         $this

diff --git a/lib/Console/Command/ConfigurationFactoryTrait.php b/lib/Console/Command/ConfigurationFactoryTrait.php
@@ -8,6 +8,8 @@
 trait ConfigurationFactoryTrait
 {
 
+    protected $factory;
+
     public function setConfigurationFactory(MagiumConfigurationFactoryInterface $factory)
     {
         $this->factory = $factory;

diff --git a/lib/Console/Command/ConfigurationGet.php b/lib/Console/Command/ConfigurationGet.php
@@ -19,8 +19,6 @@ class ConfigurationGet extends Command
 
     const COMMAND = 'magium:configuration:get';
 
-    protected $factory;
-
     protected function configure()
     {
         $this

diff --git a/lib/Console/Command/ConfigurationListKeys.php b/lib/Console/Command/ConfigurationListKeys.php
@@ -12,13 +12,12 @@
 
 class ConfigurationListKeys extends Command
 {
+    use ConfigurationFactoryTrait;
 
     const COMMAND = 'magium:configuration:list-keys';
 
     const INITIAL_MESSAGE = 'Valid configuration keys';
 
-    protected $factory;
-
     protected function configure()
     {
         $this
@@ -28,19 +27,6 @@ protected function configure()
         ;
     }
 
-    public function getConfigurationFactory()
-    {
-        if (!$this->factory instanceof MagiumConfigurationFactoryInterface) {
-            $this->factory = new MagiumConfigurationFactory();
-        }
-        return $this->factory;
-    }
-
-    public function setConfigurationFactory(MagiumConfigurationFactoryInterface $factory)
-    {
-        $this->factory = $factory;
-    }
-
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $factory = $this->getConfigurationFactory();

diff --git a/lib/Console/Command/ConfigurationSet.php b/lib/Console/Command/ConfigurationSet.php
@@ -18,8 +18,6 @@ class ConfigurationSet extends Command
 
     const COMMAND = 'magium:configuration:set';
 
-    protected $factory;
-
     protected function configure()
     {
         $this