Fixed deadlock when executing fetch request #1254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…threads simultaneously
|
Strange that CI finished building with failure status. These changes cannot affect on compilation result |
This comment has been minimized.
This comment has been minimized.
akkrat
reviewed
Sep 15, 2016
| } | ||
| else | ||
| { | ||
| [context performBlockAndWait:^{ |
|
@yevgeniy-logachev how to reproduce the deadlock ? can you demonstrate it with a piece of code? |
|
@yevgeniy-logachev could you at least rebase your branch to the current tip to see if the Travis builds can pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deadlock when executing fetch request from main and background threads simultaneously. As Apple docs say about using performBlockAndWait:
"The one exception is: if your code is executing on the main thread, you can invoke methods on the main queue style contexts directly instead of using the block based API."