Recaptcha initialization #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for include Google API js file - Admin panel
…a Frontend, all types, set param hl in call to render.
…a Admin panel, all types. Reformat code.
This was referenced Apr 3, 2020
ihor-sviziev
suggested changes
Apr 6, 2020
| @@ -50,16 +50,19 @@ define( | |||
| $(window).trigger('recaptchaapiready'); | |||
| }.bind(this); | |||
|
|
|||
| element = document.createElement('script'); | |||
| scriptTag = document.getElementsByTagName('script')[0]; | |||
| if (window.addedScriptTag === undefined) { | |||
There was a problem hiding this comment.
Could you rename variable to make it not too general?
Suggested change
| if (window.addedScriptTag === undefined) { | |
| if (window.addedRecaptchaScriptTag === undefined) { |
Or maybe even better - just add variable inside this JS file and not leak it to window at all?
There was a problem hiding this comment.
@ihor-sviziev this variable should be global.
There was a problem hiding this comment.
Could you explain why?
There was a problem hiding this comment.
Looks like we can replace global variable on new shared service.
The reCaptcha component will have dependency (via "import" by path) on this shared service.
Inside of the new service adding script tag will proceed only one time.
Thanks
engcom-Foxtrot
added
the
Component: Google reCAPTCHA
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
engcom-Foxtrot
force-pushed
the
recaptcha-initialization
branch
from
81ffeeb
to
fb34279
Compare
engcom-Foxtrot
force-pushed
the
recaptcha-initialization
branch
from
fb34279
to
2a64eee
Compare
ihor-sviziev
reviewed
Apr 7, 2020
Co-Authored-By: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
5 tasks
m2-community-project
bot
moved this from Review in Progress
to Done
in Pull Request Progress
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR accumulates commits from #183, #176 and #173
Fixed Issues (if relevant)
#21
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)