You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A version label is required. A maintainer must add one.
Messages
📖
DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
Verify content:
Error: Image size (1280x1869) different than saved snapshot size (1280x1658).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/aboutUsPage/aboutUsPage.spec.js/__diff_output__/AboutUs.diff.png
Verify content:
Error: Image was 2.0008840289507224% different from saved snapshot with 52989.81191550777 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/customerService/customerService.spec.js/__diff_output__/Customer-Service-Page.diff.png
verify column content:
Error: Image was 7.658328706604878% different from saved snapshot with 753726.5846410868 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Page-Builder-Column-Page.diff.png
,should apply mediaQuery styles:
Error: Image was 2.4061142240380584% different from saved snapshot with 48168.4818738627 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Column-media-query-(Desktop).diff.png
verify mocked google map api with two markers and click event:
Error: Image was 2.621848037935426% different from saved snapshot with 53024.25471920605 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/map.spec.js/__diff_output__/Page-Builder-Verify-Map---2-Locations.diff.png
verify divider content:
Error: Image was 20.94891106307312% different from saved snapshot with 1016541.7195534105 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/divider.spec.js/__diff_output__/Page-Builder-Divider-Page.diff.png
verify dynamic block content:
Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/dynamicBlock.spec.js/__diff_output__/Page-Builder-Dynamic-Block-Snapshot.diff.png
verify slider content:
Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page.diff.png
verify slider content 2:
Error: Image was 2.485618757482233% different from saved snapshot with 49760.09902978832 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-2.diff.png
verify slider content 3:
Error: Image was 16.88772507716221% different from saved snapshot with 338078.7458647257 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-3.diff.png
verify slider content 4:
Error: Image was 21.63970511525014% different from saved snapshot with 433209.58464321564 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-4.diff.png
verify slider content 5:
Error: Image was 21.577861648502793% different from saved snapshot with 431971.52791370713 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-5.diff.png
verify slider content 6:
Error: Image was 21.54520702443923% different from saved snapshot with 431317.8084636538 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-6.diff.png
verify slider content 7:
Error: Image was 1.0082792778816185% different from saved snapshot with 67949.95709499804 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-7.diff.png
verify slider content 8:
Error: Image was 1.582977776215655% different from saved snapshot with 55822.12830046886 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-8.diff.png
verify slider content 10:
Error: Image was 7.634317979555516% different from saved snapshot with 268630.27361021587 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-10.diff.png
verify slider content 11:
Error: Image was 4.796009316593796% different from saved snapshot with 379322.1320605833 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-11.diff.png
verify slider content 12:
Error: Image size (1280x5234) different than saved snapshot size (1280x5014).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-12.diff.png
,should apply mediaQuery styles:
Error: Image was 8.264763750401604% different from saved snapshot with 170743.40727229684 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Slider-media-query-(Desktop).diff.png
verify banner content:
Error: Image was 2.054961975679115% different from saved snapshot with 52712.24063054011 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page.diff.png
verify banner content2:
Error: Image was 40.75456985136245% different from saved snapshot with 2083504.0254251726 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page2.diff.png
verify banner content3:
Error: Image was 46.598965265993634% different from saved snapshot with 2382288.2210864457 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page3.diff.png
verify banner content4:
Error: Image was 1.2068824301607495% different from saved snapshot with 53048.758594201776 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page4.diff.png
verify banner content7:
Error: Image was 1.0861941871446734% different from saved snapshot with 53193.970688198664 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page7.diff.png
verify banner content8:
Error: Image was 1.3339226859671482% different from saved snapshot with 53186.165334882135 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page8.diff.png
verify banner content9:
Error: Image was 1.1697475861558115% different from saved snapshot with 53422.84015877038 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page9.diff.png
verify banner content10:
Error: Image size (1280x8574) different than saved snapshot size (1280x7834).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page10.diff.png
,should apply mediaQuery styles:
Error: Image was 15.00671376852356% different from saved snapshot with 510180.2466457418 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Banner-media-query-(Desktop).diff.png
verify smoke test content:
TypeError: The following error originated from your application code, not from Cypress.
Failed to execute 'unobserve' on 'IntersectionObserver': parameter 1 is not of type 'Element'.
When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
This behavior is configurable, and you can choose to turn this off by listening to the uncaught:exception event.
The response we received from your web server was:
502: Bad Gateway
This was considered a failure because the status code was not 2xx.
If you do not want status codes to cause failures pass the option: failOnStatusCode: false
should apply mediaQuery styles:
Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/tabs.spec.js/diff_output/Tabs-media-query-(Desktop).diff.png
verify block content:
Error: Image was 1.4767211508248446% different from saved snapshot with 95190.62675909014 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Block-Page.diff.png
verify block dynamic block content:
Error: Image was 1.6195690378366767% different from saved snapshot with 58998.95656554473 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Dynamic-Block.diff.png
verify block cms block content:
Error: Image was 1.6195690378366767% different from saved snapshot with 58998.95656554473 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Block.diff.png
verify block cms page content:
Error: Image was 1.4649558648462069% different from saved snapshot with 55991.785119113905 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Page.diff.png
verify row content:
Error: Image was 32.4918650999411% different from saved snapshot with 5044401.047003976 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row.diff.png
verify row content2:
Error: Image was 8.936557241857567% different from saved snapshot with 1130610.3267650586 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row2.diff.png
verify row video background3:
Error: Image was 1.1634912324169688% different from saved snapshot with 48788.44515069427 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row-Video-Background3.diff.png
,should apply mediaQuery styles:
Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels.
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Row-media-query-(Desktop).diff.png
Log
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
user should be able to filter results in Category and Search pages:
AssertionError: Timed out retrying after 30000ms: Expected to find content: '100-200' within the element: [
, 1 more... ] and with the selector: '[data-cy="FilterList-item"]' but never did.
user should be able to use radio-boolean filter results in Category and Search pages:
AssertionError: Timed out retrying after 30000ms: Expected to find content: '0-100' within the element: [
, 4 more... ] and with the selector: '[data-cy="FilterList-item"]' but never did.
user should be able to place an order as a registered customer:
CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetCustomerAfterCreateQuery`. No request ever occurred.
Registered user should be able to sign in from toast suggestion in guest checkout page:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Toast-root"], but never found it.
should be able to edit a configurable product and place an order:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.
user can fill and submit payment form and place order with inline badge position:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.
user can fill and submit payment form and place order with default badge position:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.
lets users add products to cart regardless of store view:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-root"] [data-cy="CartTrigger-counter"], but never found it.
user should be able to add and remove products from wishlist:
The response we received from your web server was:
502: Bad Gateway
This was considered a failure because the status code was not 2xx.
If you do not want status codes to cause failures pass the option: failOnStatusCode: false
user should be able to place an order as a guest with an specified Region and a credit card:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.
should be able to place an order in French store:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductOptions-Option-root"], but never found it.
should display English text and USD currency accross app if Default Store View is selected:
CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.
should display French text and EUR currency accross app if French Store View is selected:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductFullDetail-root"] [data-cy="ProductOptions-Option-root"] [data-cy="ProductOptions-Option-selectedLabel"], but never found it.
should show USD currency across app if it is selected inside French Store View:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductFullDetail-root"] [data-cy="ProductFullDetail-productPrice"], but never found it.
Log
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Search products by category from searchBar by replacing the attribute category_id by category_uid
Related Issue
Closes #4223
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist