updated release 13.3 #4200

glo82145 · 2023-11-17T10:21:06Z

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.

glo42707

Approved

pwa-studio-bot · 2023-11-17T10:28:44Z

	Fails
🚫	A version label is required. A maintainer must add one.
🚫	No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
🚫	Missing information in PR. Please fill out the "Description" section.

	Warnings
⚠️	Found the word "TODO" in the PR description. Just letting you know incase you forgot :)

	Messages
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 6cd9876

The base branch was changed.

pwa-studio-bot · 2023-11-17T10:33:48Z

	Fails
🚫	`node` failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged Verify content: Error: Image size (1280x1869) different than saved snapshot size (1280x1658). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/aboutUsPage/aboutUsPage.spec.js/__diff_output__/AboutUs.diff.png Verify content: Error: Image was 2.0008840289507224% different from saved snapshot with 52989.81191550777 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/customerService/customerService.spec.js/__diff_output__/Customer-Service-Page.diff.png verify mocked google map api with two markers and click event: Error: Image was 2.621848037935426% different from saved snapshot with 53024.25471920605 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/map.spec.js/__diff_output__/Page-Builder-Verify-Map---2-Locations.diff.png verify column content: Error: Image was 7.658328706604878% different from saved snapshot with 753726.5846410868 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Page-Builder-Column-Page.diff.png ,should apply mediaQuery styles: Error: Image was 2.4061142240380584% different from saved snapshot with 48168.4818738627 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Column-media-query-(Desktop).diff.png verify divider content: Error: Image was 20.94891106307312% different from saved snapshot with 1016541.7195534105 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/divider.spec.js/__diff_output__/Page-Builder-Divider-Page.diff.png verify dynamic block content: Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/dynamicBlock.spec.js/__diff_output__/Page-Builder-Dynamic-Block-Snapshot.diff.png verify slider content: Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page.diff.png verify slider content 2: Error: Image was 2.485618757482233% different from saved snapshot with 49760.09902978832 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-2.diff.png verify slider content 3: Error: Image was 16.88772507716221% different from saved snapshot with 338078.7458647257 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-3.diff.png verify slider content 4: Error: Image was 21.63970511525014% different from saved snapshot with 433209.58464321564 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-4.diff.png verify slider content 5: Error: Image was 21.577861648502793% different from saved snapshot with 431971.52791370713 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-5.diff.png verify slider content 6: Error: Image was 21.54520702443923% different from saved snapshot with 431317.8084636538 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-6.diff.png verify slider content 7: Error: Image was 1.0082792778816185% different from saved snapshot with 67949.95709499804 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-7.diff.png verify slider content 8: Error: Image was 1.582977776215655% different from saved snapshot with 55822.12830046886 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-8.diff.png verify slider content 10: Error: Image was 7.634317979555516% different from saved snapshot with 268630.27361021587 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-10.diff.png verify slider content 11: Error: Image was 4.796009316593796% different from saved snapshot with 379322.1320605833 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-11.diff.png verify slider content 12: Error: Image size (1280x5234) different than saved snapshot size (1280x5014). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-12.diff.png ,should apply mediaQuery styles: Error: Image was 8.264763750401604% different from saved snapshot with 170743.40727229684 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Slider-media-query-(Desktop).diff.png verify banner content: Error: Image was 2.054961975679115% different from saved snapshot with 52712.24063054011 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page.diff.png verify banner content2: Error: Image was 40.75456985136245% different from saved snapshot with 2083504.0254251726 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page2.diff.png verify banner content3: Error: Image was 46.598965265993634% different from saved snapshot with 2382288.2210864457 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page3.diff.png verify banner content4: Error: Image was 1.2068824301607495% different from saved snapshot with 53048.758594201776 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page4.diff.png verify banner content7: Error: Image was 1.0861941871446734% different from saved snapshot with 53193.970688198664 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page7.diff.png verify banner content8: Error: Image was 1.3339226859671482% different from saved snapshot with 53186.165334882135 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page8.diff.png verify banner content9: Error: Image was 1.1697475861558115% different from saved snapshot with 53422.84015877038 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page9.diff.png verify banner content10: Error: Image size (1280x8574) different than saved snapshot size (1280x7834). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page10.diff.png ,should apply mediaQuery styles: Error: Image was 15.00671376852356% different from saved snapshot with 510180.2466457418 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Banner-media-query-(Desktop).diff.png verify smoke test cms block content: TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection. Cannot read property 'hasAttribute' of undefined When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application verify smoke test dynamic block content: Error: Image was 1.2264133641294528% different from saved snapshot with 56575.92018332861 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/smokeTest.spec.js/diff_output/Page-Builder-Smoke-Test-Dynamic-Block-Content.diff.png should apply mediaQuery styles: Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/tabs.spec.js/diff_output/Tabs-media-query-(Desktop).diff.png verify block content: Error: Image was 1.4767211508248446% different from saved snapshot with 95190.62675909014 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Block-Page.diff.png verify block dynamic block content: Error: Image was 1.6195690378366767% different from saved snapshot with 58998.95656554473 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Dynamic-Block.diff.png verify block cms block content: Error: Image was 1.6195690378366767% different from saved snapshot with 58998.95656554473 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Block.diff.png verify block cms page content: Error: Image was 1.4649558648462069% different from saved snapshot with 55991.785119113905 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Page.diff.png verify row content: Error: Image was 32.4918650999411% different from saved snapshot with 5044401.047003976 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row.diff.png verify row content2: Error: Image was 8.936557241857567% different from saved snapshot with 1130610.3267650586 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row2.diff.png verify row video background3: Error: Image was 1.1634912324169688% different from saved snapshot with 48788.44515069427 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row-Video-Background3.diff.png ,should apply mediaQuery styles: Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Row-media-query-(Desktop).diff.png

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 6cd9876

pwa-studio-bot · 2023-11-17T10:34:50Z

	Fails
🚫	`node` failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to filter results in Category and Search pages: AssertionError: Timed out retrying after 30000ms: Expected to find content: '100-200' within the element: [ , 1 more... ] and with the selector: '[data-cy="FilterList-item"]' but never did. user should be able to use radio-boolean filter results in Category and Search pages: AssertionError: Timed out retrying after 30000ms: Expected to find content: '0-100' within the element: [ , 1 more... ] and with the selector: '[data-cy="FilterList-item"]' but never did. user should be able to place an order as a registered customer: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetCustomerAfterCreateQuery`. No request ever occurred. https://on.cypress.io/wait Registered user should be able to sign in from toast suggestion in guest checkout page: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="Toast-root"]`, but never found it. should be able to edit a configurable product and place an order: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user can fill and submit payment form and place order with inline badge position: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user can fill and submit payment form and place order with default badge position: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. lets users add products to cart regardless of store view: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="Header-root"] [data-cy="CartTrigger-counter"]`, but never found it. user should be able to place an order as a guest with an specified Region and a credit card: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user should be able to add and remove products from wishlist: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait should be able to place an order in French store: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="ProductOptions-Option-root"]`, but never found it. should display English text and USD currency accross app if Default Store View is selected: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait should display French text and EUR currency accross app if French Store View is selected: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="ProductFullDetail-root"] [data-cy="ProductOptions-Option-root"] [data-cy="ProductOptions-Option-selectedLabel"]`, but never found it. should show USD currency across app if it is selected inside French Store View: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="ProductFullDetail-root"] [data-cy="ProductFullDetail-productPrice"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 6cd9876

glo82145 · 2023-11-30T06:38:28Z

run lighthouse-desktop

glo82145 · 2023-11-30T07:12:04Z

run lighthouse-desktop

glo82145 · 2023-11-30T08:59:04Z

run lighthouse-desktop

The merge-base changed after approval.

updated release 13.3

6cd9876

m2-community-project bot added this to Ready for Review in Pull Request Progress Nov 17, 2023

m2-community-project bot added the Progress: ready for review label Nov 17, 2023

github-actions bot added the needs triage label Nov 17, 2023

glo42707 approved these changes Nov 17, 2023

View reviewed changes

m2-community-project bot assigned glo42707 Nov 17, 2023

m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Nov 17, 2023

m2-community-project bot added Progress: approved and removed Progress: ready for review labels Nov 17, 2023

glo42707 previously approved these changes Nov 17, 2023

View reviewed changes

glo42707 assigned glo82145 Nov 17, 2023

pwa-studio-bot closed this Nov 17, 2023

m2-community-project bot removed the Progress: approved label Nov 17, 2023

m2-community-project bot removed this from Reviewer Approved in Pull Request Progress Nov 17, 2023

glo82145 reopened this Nov 17, 2023

m2-community-project bot added this to Reviewer Approved in Pull Request Progress Nov 17, 2023

m2-community-project bot added the Progress: approved label Nov 17, 2023

glo82145 changed the base branch from main to release/13.3 November 17, 2023 10:31

m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Nov 17, 2023

m2-community-project bot added Progress: review and removed Progress: approved labels Nov 17, 2023

RaghavendraTirumalasetti previously approved these changes Nov 17, 2023

View reviewed changes

m2-community-project bot assigned RaghavendraTirumalasetti Nov 17, 2023

m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Nov 17, 2023

m2-community-project bot added Progress: approved and removed Progress: review labels Nov 17, 2023

pwa-studio-bot added the pkg:pwa-buildpack label Nov 17, 2023

m2-community-project bot removed the Progress: approved label Nov 17, 2023

pwa-studio-bot added pkg:peregrine pkg:venia-concept pkg:babel-preset-peregrine pkg:venia-ui pkg:create-pwa pkg:pagebuilder pkg:extensions labels Nov 17, 2023

m2-community-project bot removed this from Reviewer Approved in Pull Request Progress Nov 17, 2023

glo82145 restored the updated_13.3_v1 branch November 30, 2023 06:37

glo82145 reopened this Nov 30, 2023

m2-community-project bot added this to Reviewer Approved in Pull Request Progress Nov 30, 2023

m2-community-project bot added the Progress: approved label Nov 30, 2023

glo82145 closed this Nov 30, 2023

glo82145 deleted the updated_13.3_v1 branch November 30, 2023 07:20

m2-community-project bot removed the Progress: approved label Nov 30, 2023

m2-community-project bot removed this from Reviewer Approved in Pull Request Progress Nov 30, 2023

glo82145 restored the updated_13.3_v1 branch November 30, 2023 07:23

glo82145 reopened this Nov 30, 2023

m2-community-project bot added this to Reviewer Approved in Pull Request Progress Nov 30, 2023

m2-community-project bot added the Progress: approved label Nov 30, 2023

glo82145 force-pushed the release/13.3 branch from c33bf1a to 52229b2 Compare December 4, 2023 10:34

glo82145 closed this May 9, 2024

m2-community-project bot removed the Progress: approved label May 9, 2024

m2-community-project bot removed this from Reviewer Approved in Pull Request Progress May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated release 13.3 #4200

updated release 13.3 #4200

glo82145 commented Nov 17, 2023

glo42707 left a comment

pwa-studio-bot commented Nov 17, 2023 •

edited

pwa-studio-bot commented Nov 17, 2023 •

edited

pwa-studio-bot commented Nov 17, 2023 •

edited

glo82145 commented Nov 30, 2023

glo82145 commented Nov 30, 2023

glo82145 commented Nov 30, 2023

updated release 13.3 #4200

updated release 13.3 #4200

Conversation

glo82145 commented Nov 17, 2023

Description

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

glo42707 left a comment

Choose a reason for hiding this comment

pwa-studio-bot commented Nov 17, 2023 • edited

pwa-studio-bot commented Nov 17, 2023 • edited

Log

pwa-studio-bot commented Nov 17, 2023 • edited

Log

glo82145 commented Nov 30, 2023

glo82145 commented Nov 30, 2023

glo82145 commented Nov 30, 2023

pwa-studio-bot commented Nov 17, 2023 •

edited

pwa-studio-bot commented Nov 17, 2023 •

edited

pwa-studio-bot commented Nov 17, 2023 •

edited