-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-2483] Duplicated styles issue #3658
Merged
dpatil-magento
merged 2 commits into
release/12.2
from
jcharron/PWA-2483-duplicate-styles-release
Jan 24, 2022
Merged
[PWA-2483] Duplicated styles issue #3658
dpatil-magento
merged 2 commits into
release/12.2
from
jcharron/PWA-2483-duplicate-styles-release
Jan 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremycharron
added
the
version: Patch
This changeset includes backwards compatible bug fixes.
label
Jan 21, 2022
|
jimbo
approved these changes
Jan 21, 2022
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
Jan 21, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Jan 21, 2022
larsroettig
approved these changes
Jan 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work patch applied and successfully tested
QA Approved. |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Jan 24, 2022
Hi @larsroettig, how do I apply this as a patch to my scaffolded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:pwa-buildpack
Progress: done
version: Patch
This changeset includes backwards compatible bug fixes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix duplicated styles on pages and components
Introduced in release 12.0.0 with Tailwind : https://github.com/magento/pwa-studio/pull/3341/files#diff-bbf9b70c8bd565e8bdb2418aebe2b72e01037971442894d4798ee71a93dc837a
Related Issue
Closes PWA-2483
Closes #3634
Also related to PWA-2412 and issue #3547
Acceptance
Verification Stakeholders
Project maintainers
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
N/A
Is Browser/Device testing needed?
No
Any ad-hoc/edge case scenarios that need to be considered?
No
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
No breaking change
Checklist