Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-2483] Duplicated styles issue #3658

Merged

Conversation

jeremycharron
Copy link
Contributor

Description

Fix duplicated styles on pages and components
Introduced in release 12.0.0 with Tailwind : https://github.com/magento/pwa-studio/pull/3341/files#diff-bbf9b70c8bd565e8bdb2418aebe2b72e01037971442894d4798ee71a93dc837a

Related Issue

Closes PWA-2483
Closes #3634


Also related to PWA-2412 and issue #3547

Acceptance

Verification Stakeholders

Project maintainers

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  1. Inspect element on the "Add to Cart" button on the PDP and verify that its styles are not duplicated (example: class="button-content-[hash]" element)
  2. Inspect element on the "Add to Cart" button on a Category landing page and verify that its styles are not duplicated (example: class="button-content-[hash]" element)
  3. Inspect element on a product image on the Search results page and verify that its styles are not duplicated (example: class="item-image-[hash]" element)

Test scenario(s) for any existing impacted features/areas

  1. Check that build is working properly
  2. Check that Tailwind header is still showing properly

Test scenario(s) for any Magento Backend Supported Configurations

N/A

Is Browser/Device testing needed?

No

Any ad-hoc/edge case scenarios that need to be considered?

No

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

No breaking change

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jeremycharron jeremycharron added the version: Patch This changeset includes backwards compatible bug fixes. label Jan 21, 2022
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jan 21, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 21, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 2c4bcd8

Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work patch applied and successfully tested

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit d9c093a into release/12.2 Jan 24, 2022
@dpatil-magento dpatil-magento deleted the jcharron/PWA-2483-duplicate-styles-release branch January 24, 2022 16:25
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jan 24, 2022
@drpayyne
Copy link
Contributor

Hi @larsroettig, how do I apply this as a patch to my scaffolded 12.1.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pwa-buildpack Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants