Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Search products by category from searchBar doesn't work #4223

Closed
1 of 8 tasks
joseamietta opened this issue Dec 22, 2023 · 11 comments
Closed
1 of 8 tasks

[bug]: Search products by category from searchBar doesn't work #4223

joseamietta opened this issue Dec 22, 2023 · 11 comments
Assignees
@joseamietta @RaghavendraTirumalasetti
Labels
bug Something isn't working Progress: done

Comments

@joseamietta
Copy link

Describe the bug

Search products by category from searchBar doesn't work
https://venia.magento.com/search.html?query=shirt&category_id%5Bfilter%5D=Tops%2CMTg%3D&page=1

The attribute category_id is deprecated, should replace by category_uid

To reproduce

Steps to reproduce the behavior:

  1. Open top SearchBar
  2. Type 'shirt'
  3. Click on 'shirt on Top'
  4. The search.html page show No results found!
  5. if replace category_id with category_uid from URL, It's works and sidebar category filter was actived

Expected behavior

Able to search products by category from searchBar

Screenshots

image
Screenshot from 2023-12-22 11-47-34
Screenshot from 2023-12-22 11-48-00

Possible solutions

in file node_modules/@magento/peregrine/lib/talons/SearchBar/useSuggestedCategory.js, line 12 replace category_id[filter] by category_uid[filter]

Please complete the following device information:

  • Device [e.g. Lenovo Thinkpad, Notebook, Ubuntu 22.04]:
  • Browser [e.g. Chrome]:
  • Browser Version [e.g. 120.0.6099.109]:
  • Magento Version [e.g Adobe Commerce 2.4.6-p3]:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@joseamietta joseamietta added the bug Something isn't working label Dec 22, 2023
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 22, 2023

Hi @joseamietta. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

@joseamietta
Copy link
Author

@magento I am working on this

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 22, 2023

Hi @joseamietta! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@joseamietta
Copy link
Author

@magento add to contributors team

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 22, 2023

Hi @joseamietta! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@joseamietta
Copy link
Author

@magento I am working on this

@RaghavendraTirumalasetti
Copy link
Contributor

@magento I am working on this

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jan 3, 2024

Hi @RaghavendraTirumalasetti! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@RaghavendraTirumalasetti
Copy link
Contributor

Issue is reproducible with the steps Mentioned. Hence Conforming the issue.

@joseamietta joseamietta mentioned this issue Jan 8, 2024
Closed
@glo82145
Copy link
Collaborator

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3237 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joseamietta joseamietta

@RaghavendraTirumalasetti RaghavendraTirumalasetti

Labels
bug Something isn't working Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix category_id by category_uid on SearchBar useSuggestedCategory joseamietta/pwa-studio
4 participants
@joseamietta @github-jira-sync-bot @glo82145 @RaghavendraTirumalasetti