Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get correct Special Price for product from attribute and catalog rules #60

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Get correct Special Price for product from attribute and catalog rules #60

wants to merge 3 commits into from

Conversation

Bashev
Copy link

@Bashev Bashev commented Mar 15, 2024 •
edited

Fixes #59

Description (*)

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento-commerce/facebook-for-magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Bashev and others added 3 commits March 15, 2024 10:37
@Bashev
Use Final Price to get Special Price which is in the time frame or is…
2b97641 
… applied from catalog price rules.
@Bashev
Merge pull request #1 from magento/main
59ba6d7 
sync
@Bashev
Merge branch 'refs/heads/main' into sale-price-issue
04a119d 
# Conflicts:
#	app/code/Meta/Catalog/Model/Product/Feed/Builder/Tools.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sale price is not correct if comes from Catalog Price Rule
1 participant
@Bashev