New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not supported attribute tags from description. #23

Open

Bashev wants to merge 1 commit into magento:main from Bashev:remove-attributes-from-description-tags

Bashev commented Sep 13, 2023

…r empty description.

Meta not support attributes in the allowed tags used in the description (rich_description), but sometimes in they can be added from wyswyg editor. We just remove them.
Added fallback if product description and short_description are both missing, use product name instead of sending empty string.

Description (*)

Story

Bug

Task

Fixed Issues (if relevant)

magento-commerce/facebook-for-magento2#<issue_number>: Issue title

Manual testing scenarios (*)

...
...

Questions or comments

Checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)


          Remove not supported attribute tags from description. Add fallback fo…

718a124

…r empty description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment