Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sale price is not correct if comes from Catalog Price Rule #59

Open
Bashev opened this issue Mar 15, 2024 · 1 comment · May be fixed by #60
Open

Sale price is not correct if comes from Catalog Price Rule #59

Bashev opened this issue Mar 15, 2024 · 1 comment · May be fixed by #60

Comments

@Bashev
Copy link

Bashev commented Mar 15, 2024

Logic for getting prices is based on the Special Price attribute, but in case we have catalog price rule sale price in FB Catalog will not be populated. This is visible here.

if ($product->getSpecialPrice() > 0 && $product->getPrice() > $product->getSpecialPrice()) {

As additional issue we never check is this sale price in the time frame or not.

Steps to reproduce (*)

  1. Create new Catalog Price Rule - Discount everything with 10%
  2. Save product or Push catalog manually

Expected result (*)

  1. Products have sale price in the Catalog Manager

Actual result (*)

  1. Products have only regular price.
@davirs
Copy link

davirs commented Apr 29, 2024

Hello everything is fine?
@Bashev, could you confirm for me if obtaining the special price through the catalog rules is already functional?
I installed version 1.3.0 of the meta extension on my magento 2.4.6-p3, but within the product catalog on Facebook it is only pulling the default price, the catalog rules are not appearing.

image

When clicking on "See promotions in Commerce Manager" no catalog or cart rules appear.

Note: I am doing this integration through the "test" in the configured form. I don't know if there is any kind of restriction in test mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants