Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier #38646
+263
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier
The change consists using a new model that pulls the design + store cache parameters. This model is injected in both places that needs these cache information. This has meant a plugin was removed in favour of this model.
Description (*)
When the page gets loaded, the FPC checks if the page cache identifier is already saved in the cache. This reading checks the server environment variables (eg: PARAM_RUN_CODE).
When the page has been rendered, the page cache identifier is saved to prevent the same page to be reloaded the next loads the same version for it. The identifier was currently saved differently to the identifier created in the reading phase and that was breaking the cache
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Test 1: Backward compatibility - The FPC works
Setup the Magento store with no environment variable
PARAM_RUN_CODE
,PARAM_RUN_TYPE
, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the headerX-Magento-Cache-Debug
Test 2: Test the fault - The FPC works with environment variables
Setup the Magento store with some environment variables
PARAM_RUN_CODE
,PARAM_RUN_TYPE
, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the headerX-Magento-Cache-Debug
Questions or comments
Contribution checklist (*)