Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup: fixed wrong usage of sprintf, it only takes 2 placeholders here and w… #38628

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Apr 17, 2024

…e gave it 3 arguments.

Description (*)

Found with running phpstan on level 0:

 ------ ------------------------------------------------------------------------
  Line   framework-message-queue/Consumer/Config/Validator/ConsumerInstance.php
 ------ ------------------------------------------------------------------------
  42     Call to sprintf contains 2 placeholders, 3 values given.
 ------ ------------------------------------------------------------------------

This PR fixes this, it doesn't fix anything major, as the code runs fine as-is and doesn't crash. So this is only a minor cleanup.

I've left the trailing comma, since that's accepted by PHP > 8.0 and it results in cleaner git diffs.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Nothing to test, the code wasn't behaving wrong before, this is just a minor cleanup.
The unit test for this class already tests for the correct exception message, so if unit tests are green, this can be considered good enough.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Apr 17, 2024

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@hostep
Copy link
Contributor Author

hostep commented Apr 17, 2024

@magento run all tests

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 17, 2024
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants