Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-fix PR 37477 : After changing foreach method to for method, the "return" should be replaced with "continue" #38537

Conversation

LeonidTomashevskyAmasty
Copy link

@LeonidTomashevskyAmasty LeonidTomashevskyAmasty commented Mar 21, 2024

Description (*)

The commit 5b931fe replaces forEach with for in processAdded. return inside of forEach works like continue, but for now there is break, and it change logic.

The new behavior broke multiple wysiwig elements on a same page. because wysiwig uses dom-element with the same element selector.

Related Pull Requests

  1. Improve product edit page loading speed #37477

Fixed Issues (if relevant)

  1. [Issue] Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic #38305

Manual testing scenarios (*)

  1. Adminhtml page with more then one wysiwig element on the same page
  2. Write some information in all wysiwig inputs
  3. Save

Actual result: saved only the firs wysiwig element data, other inputs are empty
Expected result: all inputs should have saved information

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Mar 21, 2024

Hi @LeonidTomashevskyAmasty. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@LeonidTomashevskyAmasty
Copy link
Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 26, 2024
@sprankhub
Copy link
Member

Looks like this was duplicated by #38623, which seems to gain more traction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Amasty partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants