Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrectly cased namespace usages. #37574

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ protected function setUp(): void
->setMethods(['methods'])
->getMock();

$giftMessageSave = $this->getMockBuilder(\Magento\Giftmessage\Model\Save::class)
$giftMessageSave = $this->getMockBuilder(\Magento\GiftMessage\Model\Save::class)
->disableOriginalConstructor()
->getMock();

Expand Down
7 changes: 4 additions & 3 deletions app/code/Magento/Tax/Block/Item/Price/Renderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Magento\Framework\Pricing\Render as PricingRender;
use Magento\Framework\View\Element\Template\Context;
use Magento\Quote\Model\Quote\Item\AbstractItem as QuoteItem;
use Magento\Sales\Model\Order\CreditMemo\Item as CreditMemoItem;
use Magento\Sales\Model\Order\Creditmemo\Item as CreditMemoItem;
use Magento\Sales\Model\Order\Invoice\Item as InvoiceItem;
use Magento\Sales\Model\Order\Item as OrderItem;
use Magento\Tax\Helper\Data as TaxHelper;
Expand Down Expand Up @@ -106,6 +106,8 @@ public function setZone($zone)
}

/**
* Get store id
*
* @return int|null|string
*/
public function getStoreId()
Expand Down Expand Up @@ -201,8 +203,7 @@ public function formatPrice($price)
}

/**
* Get item price in display currency or order currency depending
* on item type
* Get item price in display currency or order currency depending on item type
*
* @return float
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,22 @@
use Magento\Framework\Api\SearchCriteria\CollectionProcessor\JoinProcessor\CustomJoinInterface;
use Magento\Framework\Data\Collection\AbstractDb;

/**
* Class CalculationData
* @package Magento\Tax\Model\Api\SearchCriteria\JoinProcessor
*/
class CalculationData implements CustomJoinInterface
{
/** Alias of table, that will be joined */
const CALCULATION_DATA_ALIAS = "cd";
public const CALCULATION_DATA_ALIAS = "cd";

/**
* Apply join to collection
*
* @param \Magento\Tax\Model\ResourceModel\Calculation\Rule\Collection $collection
* @return bool
*/
public function apply(AbstractDb $collection)
{
$isNotApplied = !array_key_exists(
self::CALCULATION_DATA_ALIAS,
$collection->getSelect()->getPart(\Magento\Framework\Db\Select::FROM)
$collection->getSelect()->getPart(\Magento\Framework\DB\Select::FROM)
);
if ($isNotApplied) {
$collection->joinCalculationData(self::CALCULATION_DATA_ALIAS);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
namespace Magento\Framework\Setup\Declaration\Schema\DataSavior;

use Magento\Framework\App\ResourceConnection;
use Magento\Framework\Db\Select;
use Magento\Framework\DB\Select;

/**
* Yields data from database by select objects
Expand Down