Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Font CSP Paylater Popup #37401

Merged
merged 4 commits into from
May 28, 2024

Conversation

in-session
Copy link
Contributor

@in-session in-session commented Apr 20, 2023

Paylater Popup:
Refused to load the font 'https://www.paypalobjects.com/webstatic/mktg/2014design/font/PP-Sans/PayPalSansBig-Medium.woff' because it violates the following Content Security Policy directive

Update:
Refused to frame 'https://www.paypalobjects.com/' because it violates the following Content Security Policy directive:

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Missing Font CSP Paylater Popup #38624: Missing Font CSP Paylater Popup

Paylater Popup: 
Refused to load the font 'https://www.paypalobjects.com/webstatic/mktg/2014design/font/PP-Sans/PayPalSansBig-Medium.woff' because it violates the following Content Security Policy directive
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2023

Hi @in-session. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Bravo engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Apr 20, 2023
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 20, 2023
@mrtuvn mrtuvn added Component: Paypal Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 29, 2023
@mrtuvn
Copy link
Contributor

mrtuvn commented May 8, 2023

Here is one example for speed-up improve merge process. When risk low and changes small i think we can have option merge for some maintainer can ability to merge immediately(Require at least two reviewer accept)

Refused to frame 'https://www.paypalobjects.com/' because it violates the following Content Security Policy directive:
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Apr 7, 2024
@m2-community-project m2-community-project bot added this to Pending Review in Community Dashboard Apr 7, 2024
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Apr 7, 2024
@engcom-Hotel engcom-Hotel self-requested a review April 16, 2024 07:52
@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Apr 16, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-community-project m2-community-project bot moved this from Review in Progress to Pending Review in Community Dashboard Apr 16, 2024
@m2-community-project m2-community-project bot moved this from Review in Progress to Pending Review in Community Dashboard Apr 16, 2024
@m2-community-project m2-community-project bot moved this from Review in Progress to Pending Review in Community Dashboard Apr 16, 2024
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Community Dashboard Apr 16, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 16, 2024
@engcom-Charlie engcom-Charlie self-assigned this Apr 19, 2024
@engcom-Charlie engcom-Charlie moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 22, 2024
@engcom-Charlie
Copy link
Contributor

Hi @in-session,

Thank you for your contribution!

In order to proceed further on this PR, I have followed the below steps on 2.4-develop
1. Setup Paypal Express checkout in admin
2. Set Enable In-Context Checkout Experience to "Yes"
3. In Advertise PayPal Pay Later section select "Yes" for "Enable PayPal Pay Later". Enabled it on Home page, Catalog Product Page
4. Visit storefront
5. On home page we can see PayPal pay later button. Clicked on it.

✔️ QA Passed

Before: ✖️
Got errors in console about woff font because of violating CSP
image

After: ✔️
Not getting error about WOFF
image

Since the build is failing, currently moving it further in Extended Testing.

Thank you!

@engcom-Charlie engcom-Charlie moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Apr 23, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

@engcom-Charlie
Copy link
Contributor

@magento run WebAPI Tests

@engcom-Charlie
Copy link
Contributor

@engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Apr 24, 2024
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 4bfee41 into magento:2.4-develop May 28, 2024
9 of 12 checks passed
@engcom-Echo engcom-Echo moved this from Merge in Progress to Recently Merged in Community Dashboard May 28, 2024
@in-session in-session deleted the patch-16 branch May 28, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Paypal Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community Risk: low Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Community Dashboard
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Missing Font CSP Paylater Popup
7 participants