#26637: Fixing issue with Invalid customer id

[srenon]

Description (*)

Invalid customer ID issue coming on the checkout while placing the order. This issue comes randomly for the customers who are logged in on the website. This issue is related to the customer quote, the table quote_address stays empty for this quote.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Invalid address id at check out #23618 : Invalid address id at check out

Manual testing scenarios (*)

1. Disable guest checkout
2. While still logged out, add an item to your cart (has this issue with downloadable product)
3. Then click checkout
4. On the log in screen. Log in with a customer that already has a save cart and billing info

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @srenon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered only manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s). <test-build(s)> is a comma-separated list of build names. Allowed build names are Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests.

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @srenon,
Could you do following?

• apply suggested change with simplification
• add some data upgrade script that will update all quotes with incorrect data in DB? (see example The shipping information was unable to be saved. verify the input data and try again. #23908 (comment))
• cover your change with any type of automated tests?

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Seems like this PR also fixes #23908

[engcom-Hotel]

@magento run all tests

[ihor-sviziev]

@engcom-Hotel tests still failing, could you check it ?

[engcom-Hotel]

@ihor-sviziev will check it.

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Moving to correct status. Tests should be adjusted.

[engcom-Hotel]

Hello @srenon
Could you please provide more detailed steps to reproduce the issue?
Thank you.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @srenon.
Please respond to my previous comment. Otherwise, PR could be closed due to inactivity.
Thank you.

[JKetelaar]

Still facing this issue, though with this PR it's fixed - so please do not close it...

[engcom-Hotel]

@JKetelaar could you please provide detailed steps to reproduce the issue?
Thank you.

[engcom-Hotel]

Hello @srenon,
Closing the PR due to inactivity.
Please feel free to reopen it.
Thanks.

[m2-assistant]

Hi @srenon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[groomershop-mt]

In our case this commits also don't fix problem at Magento 2.4.2.

[barryvdh]

@groomershop-mt did you apply this patch?