Eliminate the need for inheritance for action controllers

[antonkril]

By design, all Magento action controllers should implement \Magento\Framework\App\ActionInterface. But some crucial request processing behavior (event dispatching, authorisation, etc) resides in classes like \Magento\Framework\App\Action\Action and \Magento\Backend\App\AbstractAction. So if an action controller implements the ActionInterface but does not inherit from one of these "layer supertype" classes, it will lose that crucial behavior.

So, Magento module developers do not have a way to create an action controller without using inheritance. To avoid inheritance (see why), the request processing behavior should be extracted from "layer supertypes". Proposed solution is to move the behavior to action controller plugins.

Action controller should contain only its custom behavior.

AC:

• module developer does not have to extend from any class to create a fully functional action controller, implementing \Magento\Framework\App\ActionInterface is enough
• controllers "supertypes" (\Magento\Backend\App\AbstractAction, \Magento\Framework\App\Action\Action, \Magento\Framework\App\Action\AbstractAction) are deprecated
• magento supports both controller implementations (inheritance based and non-inheritance based)
• [optional] controllers are migrated

[mcspronko]

@antonkril Can you please assign me? :)

[maksek]

@mcspronko, thank you for taking the feature, let me know if you need some help with it.

[antonkril]

If @mcspronko takes it, I am sure it will be done :)

[okorshenko]

Hi @mcspronko do you have any progress on this or should we un-assign this ticket from you?

[mcspronko]

Hi @okorshenko I am working on it right now. Please leave it with me. Appreciate it.

[7ochem]

Can you guys remove the [up for grabs] label?

[okorshenko]

Hi @7ochem
Why we should remove this label?

[7ochem]

Hi @okorshenko, because it's not up for grabs anymore as it is being picked up by @mcspronko as I read correctly? Or doesn't it work like that?

[okorshenko]

@7ochem the issue type is still Up For Grabs. If you are interested in this implementation, you can join @mcspronko and work together.

Please let us know if you would like to

[mcspronko]

@7ochem I would be more than happy to share controllers refactoring for all modules. There are lots of work to share :)

[okorshenko]

Hi @mcspronko do you have any progress on this? Thank you

[7ochem]

@mcspronko I did not have time to respond. I'm in the middle of a "private project" (👶) so don't have much time to invest.

I feel @okorshenko is pushing this though because Magento wants to have it in the 2.2 release, am I guessing this right?

If you @mcspronko like to share your progress with me, I could spend any hour I can free up to assist on this.