Base image placeholder issue

[Bravarg]

Steps to reproduce

1. Install Magento from develop branch.
2. In admin panel Stores -> configuration -> Catalog -> Catalog -> Product Image Placeholders. Attach new picture for "base image".

Expected result

1. New product image placeholder should be new uploaded image.

Actual result

1. There are still old placeholder.
2. On frontend catalog product page there are still basic placeholder
   But take a look, that in meta data there are correct new placeholder path
   
   Looks like there is an issue in method Magento\Catalog\Helper\Image::getPlaceholder($placeholder) that handle the placeholder path from 'Magento_Catalog::images/product/placeholder/' . $placeholder . '.jpg'.

[katmoon]

Hi @Rawick

Thank you for such a good issue description. I could easily reproduce the bug and created MAGETWO-53036 ticket to fix it.

Thanks,
Kateryna.

This issue appeared to be resolved in 2.1.2 but is back in 2.1.3.

[TClilMouse]

Confirmed issue in 2.1.3

[tac2catdev]

I'm getting it on 2.1.2

[simonrl]

I am also getting it on 2.1.2;
my v 2.1.2 was installed on October 6th with composer, but still has the old lines as seen in the fix in vendor/magento/Block/Product/View/Gallery.php

[tac2catdev]

So looks like getDefaultPlaceholderUrl() is also called in the getUrl() function of Magento/Catalog/Helper/Image.php on Line 519.

May or may not be the core issue, and not sure what the submission process is, so just posting here.

[siliconalchemy]

For whatever reason this fix was pushed to develop branch but never made it into the 2.1 branch.